-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show system notifications #510
base: main
Are you sure you want to change the base?
feat: show system notifications #510
Conversation
3b70dcb
to
d5216e5
Compare
d5216e5
to
a9b9a03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. It's at least the second time we're using this pattern so it could be good to move the repeated bits to a trait if possible.
Once the branch is updated I'll test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻 Excellent stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems strange. It's a very terrible UX experience. But this isn't normal. Shouldn't we be able to prompt for notifications permission or something similar instead of trying to use notifications, and showing the Choose Application dialog. I feel like there's a step missing somewhere. |
Its old Pr, I can go back and review how I've implemented this and if there is some other option but as far as I remember this was best that I could made in decent amount of time that would work more or less |
It may be useful to use Tauri's existing plugin for system notifications: https://github.com/tauri-apps/tauri-plugin-notification It should allow us to perform actions like ensuring we have permission before sending. It also appears to handle the OS dependent sending switches. |
That was first thing that I tried but it didn't work at all. At least with my setup |
on hold until the tauri v2 upgrade is done, as we suspect the API will become easier to deal with. |
Moving this into the Todo list. Once V2 is merged let's revisit the tauri notifications plugin, and see if we can get rid of the weird "Choose application" dialog in mac os. |
7ba3886
to
18abb60
Compare
[ New Feature ] => Notifications
Implemented reusable method for triggering display of system notifications with desired title and body message
Platform specifics
Linux:
Windows
MacOS
[ @tauri-apps/plugin-notification ]
Currently implemented and replaced old implementation with official tauri plugin
After testing it looks like it work similar as my implementation or even slightly worse
Platform specifics
Linux:
Windows
ON DEV
displayed as if they have been send from powershellON BUILD
displayed with proper tari iconMacOS