-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): cleanup animation states #325
Merged
stringhandler
merged 9 commits into
tari-project:main
from
shanimal08:shanimal/sync-states
Sep 9, 2024
Merged
fix(ui): cleanup animation states #325
stringhandler
merged 9 commits into
tari-project:main
from
shanimal08:shanimal/sync-states
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use useShallow - refactor block height accent - update animation rotation - refactor useBalance logic a little and renamed
shanimal08
force-pushed
the
shanimal/sync-states
branch
from
September 9, 2024 07:56
4b64a8c
to
7ee8e7e
Compare
shanimal08
requested review from
stringhandler,
NovaT82 and
mmrrnn
and removed request for
stringhandler
September 9, 2024 10:21
'no-console': ['warn', { allow: ['info', 'warn', 'debug', 'error'] }], | ||
'no-console': [ | ||
'warn', | ||
{ allow: ['info', 'warn', 'debug', 'error', 'group', 'groupCollapsed', 'groupEnd'] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LayoutGroup
andlayout
prop to prevent janky re-renders on animations that affect the layout (majority of file changes)useShallow
when grabbing data from zustand stores which are updated every second inuseGetStatus
(majority of file changes)BlockHeightAccent
component which handles the big number resizing in isolationuseBalanceInfo
touseBalanceChanges
and updated logic a bit:useVisualisation
, in different places):useCallback
forsuccess
andfail
animations since they depend on the widow being in view + fail animation has the timing depssetAnimationState
directly for start, stop, and pausecreate
helper so we can reset to initial states on shut downMotivation and Context
How Has This Been Tested?
start.fail.and.success.mp4
accent.resize.mp4