fix(ui): horizontal scroll on windows #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The sizing looks good. The background number just needs to move to the right a bit. On the design the bottom of the text is 4px from the right hand side of the screen. Attaching the design here so you can see: |
|
i found out it can't be that close since the scroll appears. I'll try to reorganise those 3 elements to be styled independently
|
mmrrnn
force-pushed
the
fix_horizontal_scroll_on_windows
branch
from
d77476c to
1dd1a56
Compare
|
Text is now practically on the exact right. It just looks like numbers are spaced from the right, but take a look at the comma. |
|
Looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scrollbar appears because font size is too large in the
BlockHeightBgcontainer - it's horizontal large text.I tried to handle it as much responsive as possible - for different screen sizes and block number length.
Motivation and Context
How Has This Been Tested?
Tested on Windows Virtual Machine and Ubuntu
What process can a PR reviewer use to test or verify this change?
Breaking Changes