feat: add gems #168
Merged
feat: add gems #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description --- Adds authentication connection with the airdrop site. Generates a temporary uuid (which would expire after 5 minutes) After triggering the log in button it checks for tokens using this generated UUID This flow avoids the use of deeplinking Motivation and Context --- We need a way to connect miners to their airdrop accounts in order to get rewards How Has This Been Tested? --- Manually, this is a partial integration at the moment logging the tokens What process can a PR reviewer use to test or verify this change? --- Check in the console if their auth tokens are being displayed after sign in <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> --------- Co-authored-by: Erika <[email protected]> Co-authored-by: stringhandler <[email protected]> Co-authored-by: Marcin Papież <[email protected]> Co-authored-by: stringhandler <[email protected]>
Description Update gems branch --- Motivation and Context --- How Has This Been Tested? --- What process can a PR reviewer use to test or verify this change? --- <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> --------- Co-authored-by: Erika <[email protected]> Co-authored-by: stringhandler <[email protected]>
## Description - Adds heartbeat signal for metrics data. Further details are described in issue: #158 --- Motivation and Context --- How Has This Been Tested? --- What process can a PR reviewer use to test or verify this change? --- <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> --------- Co-authored-by: Erika <[email protected]> Co-authored-by: stringhandler <[email protected]> Co-authored-by: Misieq01 <[email protected]>
Description --- Motivation and Context --- How Has This Been Tested? --- What process can a PR reviewer use to test or verify this change? --- <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Description --- Integration for token set and refresh Motivation and Context --- How Has This Been Tested? --- What process can a PR reviewer use to test or verify this change? --- <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
PanchoBubble
approved these changes
Aug 28, 2024
stringhandler
commented
Aug 29, 2024
| } | ||
|
|
||
| #[derive(Debug, Deserialize, Serialize)] | ||
| pub enum TelemetryNetwork { |
There was a problem hiding this comment.
nit: Why not use the full name and just use serde(lowercase)?
| } | ||
| }); | ||
|
|
||
| if telemetry_collection_enabled { |
There was a problem hiding this comment.
nit: perhaps do this before checking the JWT above, otherwise, every loop it will decode the jwt
src-tauri/src/telemetry_manager.rs
Outdated
| } | ||
|
|
||
| async fn send_telemetry_data(data: TelemetryData, airdrop_access_token: Option<String>) { | ||
| debug!("Telemetry data being sent: {:?}", data); |
There was a problem hiding this comment.
logs must have a LOG_TARGET so that they go into the correct file
BalazsSevecsek
force-pushed
the
feature/gems
branch
from
abfe85a to
d35bf20
Compare
stringhandler
commented
Aug 29, 2024
- Reverts button config changes to match the design system
Removes duplicate code from the Settings component after merge synchronization with the main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working feature branch for adding gems