fix(ui): progress bar get stuck #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can skip to 1:55 Screencast.from.26.08.2024.17.33.56.webm |
Co-authored-by: Juan De Luca <[email protected]>
…ect#215) Description --- Added a nice "floating" animation to the Meditating Soon character on the initial setup screen. Video of the animation: https://www.loom.com/share/d7c4f7bfbadf480abdae47f73f027b78?sid=27890e94-314e-416d-842d-410b1c480648 Motivation and Context --- Just adding a little personality How Has This Been Tested? --- Running on local Dev, Mac M1 Pro What process can a PR reviewer use to test or verify this change? --- 1. On the initial setup screen when the app first loads, the SOON character should be floating up and down. Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify
Description --- Scrollbar appears because font size is too large in the `BlockHeightBg` container - it's horizontal large text. I tried to handle it as much responsive as possible - for different screen sizes and block number length. Motivation and Context --- How Has This Been Tested? --- Tested on Windows Virtual Machine and Ubuntu What process can a PR reviewer use to test or verify this change? --- <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
…ari-project#185) Description --- - add `contextmenu` listener to disable right click if not on local dev mode - added missing `useEffect` and `useMemo` deps in `useMiningControls` - added `persist` to UI store so `isMiningEnabled` isn't lost on reload (so we can actually remove the `contextmenu` listener if we want) - updated `useVisualisation` so we only set the animation state if the window is not minimised, and focused or visible. (for fail and success states) - neatened up `useBalanceInfo` a bit Motivation and Context --- failure and success block animations would run once returning to the app window after a while of being away since the animation states would be queued up
Description --- - set up daily interval to check for app updates per the [Tauri docs](https://tauri.app/v1/api/js/updater#checkupdate) - renamed `useGetApllicationsVersions` file to `useVersions` and split out the logic to specific hooks: - `useApplicationsVersions` specifically for the re/fetch versions fns (used in settings) - `useVersions`, used in `useSetup` to check that all the applications versions are present - `useMainAppVersion` with the daily check Motivation and Context --- - resolves tari-project#121
…ri-project#5) Description --- Motivation and Context --- How Has This Been Tested? --- What process can a PR reviewer use to test or verify this change? --- <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> --------- Co-authored-by: stringhandler <[email protected]>
Description --- Implemented internationalization with initial support for English and Polish Motivation and Context --- We want to support multiple languages How Has This Been Tested? --- Manually What process can a PR reviewer use to test or verify this change? --- Go to settings and change between languages <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Description --- Adjusted state transitions and changing mode behavior Motivation and Context --- Issues: - When not mining and changing mode it would start mining - Mining and changing mode would cause weird state flickering's How Has This Been Tested? --- Manually What process can a PR reviewer use to test or verify this change? --- Play around with mining and changing mode <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Working feature branch for adding gems --------- Co-authored-by: Juan <[email protected]> Co-authored-by: Erika <[email protected]> Co-authored-by: Marcin Papież <[email protected]> Co-authored-by: Sevecsek Balázs <[email protected]> Co-authored-by: Misieq01 <[email protected]> Co-authored-by: Balazs Sevecsek <[email protected]> Co-authored-by: Juan De Luca <[email protected]>
|
Cannot be merged until node has GetSyncProgress permission: |
mmrrnn
force-pushed
the
progress_bar_get_stuck
branch
from
dadda02 to
e3315ee
Compare
mmrrnn
force-pushed
the
progress_bar_get_stuck
branch
from
e3315ee to
658ee85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.