Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): wallet & seedword styling fixes #1146

Merged
merged 14 commits into from
Nov 28, 2024

Conversation

shanimal08
Copy link
Collaborator

@shanimal08 shanimal08 commented Nov 28, 2024

Description

  • bumped outdated packages & removed react-lottie in favour of @lottiefiles/dotlottie-react package from Lottie
  • fixed the disabled state when pasting seed words - now checks for both isDirty and hasChanges
  • allowed for copying of seed words even if you've not selected to view them
  • styling changes re. ^ seed words copying & wallet addresses:
    • made the copy and edit icons use small IconButtons
    • adjusted the Stack and wrapper components so all the input's and address displays have consistent widths
    • aligned Tari and Monero address font styling
  • fixed wallet history time formatting

Motivation and Context

resolves:

How Has This Been Tested?

  • locally:
Screen.Recording.2024-11-28.at.11.mp4

** wallet settings & input consistency **

before after
image image
image image

** seed word edit**

before after
image image

time fmt

before after
image image

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@shanimal08 shanimal08 marked this pull request as ready for review November 28, 2024 09:47
@shanimal08 shanimal08 requested a review from brianp November 28, 2024 09:49
@brianp brianp merged commit 98d2398 into tari-project:main Nov 28, 2024
9 checks passed
@shanimal08 shanimal08 deleted the fix/wallet-ui branch November 28, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants