Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if app in application folder for permissions #1143

Merged

Conversation

mmrrnn
Copy link
Collaborator

@mmrrnn mmrrnn commented Nov 27, 2024

Closes: #1049

Description

The problem is when Tari Universe application is not moved to the Applications directory or executed copy that is not the same as one inside Applications directory(app is copied to the Application directory when "installing" the app so user can still run the copy without sufficient privileges)

2024-11-27 10:44:15.417943000 INFO  "New Tari Universe version available" {
  "version": "0.7.7",
  "date": "2024-11-24 9:24:28.921 +00:00:00",
  "body": "Tari Universe - See the assets to download this version and install"
}
 2024-11-27 10:44:15.418214000 INFO  "Proceed with auto-update"
 2024-11-27 10:44:15.418490000 INFO  "New Tari Universe version available" {
  "version": "0.7.7",
  "date": "2024-11-24 9:24:28.921 +00:00:00",
  "body": "Tari Universe - See the assets to download this version and install"
}
 2024-11-27 10:44:15.431822000 INFO  "Updater event" "Log Item" "PENDING"
 2024-11-27 10:44:18.314768000 INFO  "Updater event" "Log Item" "DOWNLOADED"
 2024-11-27 10:44:18.458582000 INFO  "Updater event" "Tauri API error: Read-only file system (os error 30)" "ERROR"
 2024-11-27 10:44:18.458924000 ERROR "AutoUpdate error:" "Tauri API error: Read-only file system (os error 30)"
 2024-11-27 10:44:21.571906000 INFO  "Updater event" "Log Item" "PENDING"
 2024-11-27 10:44:25.508271000 INFO  "Updater event" "Log Item" "DOWNLOADED"
 2024-11-27 10:44:25.690117000 INFO  "Updater event" "Tauri API error: Read-only file system (os error 30)" "ERROR"

How to test it

Only works on MacOS build: Install .dmg application without moving the app file to the Applications folder. Run the application and check whether the critical issue dialog appeared forcing user to exit the app. In every other case it should not appear

@mmrrnn
Copy link
Collaborator Author

mmrrnn commented Nov 28, 2024

Screenshot from 2024-11-28 23-04-26
image

@mmrrnn mmrrnn marked this pull request as ready for review November 29, 2024 08:20
@brianp brianp merged commit e54cf14 into tari-project:main Dec 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.6+ Windows: auto update kills the app
2 participants