Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): permissions on intro & updated settings with anon id #1128

Merged
merged 15 commits into from
Nov 28, 2024

Conversation

shanimal08
Copy link
Collaborator

@shanimal08 shanimal08 commented Nov 26, 2024

Description

  • add created_at field to app_config to check if it's the first ever run of the app or not (to hide permissions toggle on the Intro screens on subsequent runs)
  • added Application Information settings section in General Settings to display the anon_id which can be copied
  • tightened up General Settings styling a little

Motivation and Context

resolves:

How Has This Been Tested?

  • locally:
Screen.Recording.2024-11-26.at.16.mp4

What process can a PR reviewer use to test or verify this change?

re. #1123:

  • reset everything/remove app_config and start app - should show permissions toggle on the intro screens
  • on any runs after that (not after reset) it shouldn't show on intro screens

re. #1114:

  • your app anon_id should be viewable and copy-able(?) from general settings

@shanimal08 shanimal08 changed the title fix: permissions on intro & updated settings with anon id fix(ui): permissions on intro & updated settings with anon id Nov 26, 2024
@shanimal08 shanimal08 marked this pull request as ready for review November 26, 2024 14:44
<SettingsGroupContent>
<Stack direction="row" alignItems="center" justifyContent="flex-start">
{/* eslint-disable-next-line i18next/no-literal-string */}
<Typography variant="p">Anon ID: {anon_id}</Typography>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled string check because anon_id is a field name we don't translate, but LMK if that should also be translated

Copy link
Collaborator

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anon id looks good. Copys fine.

Telemetry toggle stays on the splashscreen on every start despite the new app config option for creation date. Tested with existing wallet, and fresh install.

@shanimal08 shanimal08 marked this pull request as draft November 27, 2024 12:27
@shanimal08 shanimal08 marked this pull request as ready for review November 27, 2024 14:34
@shanimal08 shanimal08 requested a review from brianp November 27, 2024 14:34
@brianp brianp merged commit 55a0ce2 into tari-project:main Nov 28, 2024
9 checks passed
@shanimal08 shanimal08 deleted the fix/analytics_toggle branch November 28, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants