fix: prevent reset app dialog after copying monero address #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanimal08
approved these changes
Nov 25, 2024
brianp
reviewed
Nov 25, 2024
|
Tested successfully on Windows 11, app version 0.7.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent reset app dialog popping up when user copies monero address
Closes: #856
Motivation and Context
We should show this dialog only when user changes monero address.
How Has This Been Tested?
Run on ubuntu and windows, repeatedly clicked monero address multiple times and the dialog did not show up.
What process can a PR reviewer use to test or verify this change?
Same as above.
Breaking Changes