Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): bring fonts inline to optimize loading and remove more unused fonts #1098

Merged
merged 5 commits into from
Nov 21, 2024
Merged

fix(ui): bring fonts inline to optimize loading and remove more unused fonts #1098

merged 5 commits into from
Nov 21, 2024

Conversation

peps
Copy link
Collaborator

@peps peps commented Nov 21, 2024

This PR is an effort to improve animation and font performance, especially on windows.

  • Load fonts inline in the index.html head instead of from styled-components
  • Remove all unused fonts
  • Remove GTAmerica font since it was only used in 1 place ( the history items ). Poppins looks fine here as well.

@peps peps self-assigned this Nov 21, 2024
@peps peps requested review from shanimal08 and brianp November 21, 2024 07:51
@peps peps changed the title fix(ui): bring fonts inline to optimize loading and remove more unused fonts fix(ui): bring fonts inline to optimize loading and remove more unused fonts Nov 21, 2024
@peps peps marked this pull request as draft November 21, 2024 07:55
@peps peps marked this pull request as ready for review November 21, 2024 07:56
shanimal08
shanimal08 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@shanimal08 shanimal08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, d'ya wanna just delete the stuff in theme/fonts too though :D

@peps
Copy link
Collaborator Author

peps commented Nov 21, 2024

LGTM, d'ya wanna just delete the stuff in theme/fonts too though :D

done

brianp
brianp approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Game changer on windows.

@brianp brianp merged commit 5a653b9 into tari-project:main Nov 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanimal08 shanimal08 shanimal08 approved these changes

@brianp brianp brianp approved these changes

Assignees

@peps peps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peps @brianp @shanimal08