chore: add translation content json files to .pretterignore #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peps
requested review from
shanimal08,
PanchoBubble,
brianp and
stringhandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever I make a change to the translation
jsonfiles in/public/locales/en/*.jsonit changes the format for the whole file, which is annoying and a little risky. Merge conflicts are more common and we should be able to track the specific changes within these files when doing code review.My solution is just to have Prettier ignore these translation files. Alternatively, to solve this problem we could update all automation scripts to match our prettier settings... but this is simpler.
Let me know if your thoughts on this change, any objections?