-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): release notes section in settings modal #1068
Conversation
That scroll bar will become infinitely long as we continue. Would it be possible to collapse older sections to create a list of release versions and dates that can be expanded? |
Sure, its possible, ill add some custom parsing to make it happen |
public/ReleaseNotes.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was generated using AI, it needs real content before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also re. this file - i wonder if we shouldn't have translated version of it too? 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shanimal08 hm probably... It's not my call, but I personally think we should launch with english first then add multi-lang in a future iteration. Im not sure how complicated it would be to set up this ReleaseNotes.md
file with auto-translations and don't want that holding this PR up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & tested - looks great:D
public/ReleaseNotes.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also re. this file - i wonder if we shouldn't have translated version of it too? 😬
Additional item talked about today: If we're linking to a remote file it's possible someone on an older version would receive the updated file seeing notes for a version they don't have. If the version they are on, is older than that of the notes lets add a big Upgrade button/banner. |
…nto release-notes-ui
Tested successfully on a MacBook Pro M1 2020 13 inch Sequoia 15.1.1 on Testnet v0.8.7. |
This PR adds a Release Notes section to the settings modal. The release notes themselves are stored in a markdown file in the public folder called
CHANGELOG.md
package.json update - I added a new dependancy
react-markdown
to parse the markdown file.The first version in the list is open by default, the rest of the entries are collapsed and can be toggled open.
A
upgrade
button is shown if there is a new version of the app available.