-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Windows Build Instructions Revision #6734
base: development
Are you sure you want to change the base?
Feat: Windows Build Instructions Revision #6734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments around OpenSSL, otherwise LGTM
Once installed, you'll need to also set the OpenSSL environmental path. Use the following command to set an system-wide environmental path for OpenSSL: | ||
|
||
```powershell | ||
setx /m PATH "$Env:Path;C:\vcpkg\installed\x64-windows-static\bin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather prepend the OpenSSL path here to ensure it is the first one encountered if the user has another OpenSSL installation in the path
```powershell | ||
setx /m PATH "$Env:Path;C:\vcpkg\installed\x64-windows-static\bin" | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now verify that the installation has been done correctly.
This must print the two values:
echo $env:OPENSSL_CONF $env:OPENSSL_DIR
eg.
C:\vcpkg\installed\x64-windows-static\bin\openssl.cfg
C:\vcpkg\installed\x64-windows-static
This must show where OpenSSL is installed. The one installed here must be listed first if multiple versions are installed.
Get-Command openssl -All
eg.
CommandType Name Version Source
----------- ---- ------- ------
Application openssl.exe 3.4.0.0 C:\vcpkg\installed\x64-windows-static\bin\openssl.exe
Application openssl.exe 1.1.1.9 C:\Strawberry\c\bin\openssl.exe
I think we need SQLite3 as well. I renamed my sqlite3 installation location and got this error:
|
Description
Mildly revised the instructions for installing the various dependencies required to build Tari on Windows, incorporating some additional comments from others who attempted to run it on Windows 11. I've also revised the main readme to link to these instructions in the Windows section.
Motivation and Context
Lee updated the Windows build instructions to account for the latest changes to the process. I've revised it slightly and removed some extraneous info from some of the sample boxes.
How Has This Been Tested?
Not tested as I only have a Mac machine for work.
What process can a PR reviewer use to test or verify this change?
Run through the instructions on a clean Windows environment and confirm that Tari can be successfully built from source.
Breaking Changes