Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: implement command inclusion proof for eviction #6724

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Dec 12, 2024

Description

Add and verify command inclusion proof

Motivation and Context

Adds a JMT implementation to tari_jellyfish crate. Useful for state tree inclusion proofs. Currently used to validate eviction command commit proofs

How Has This Been Tested?

Cucumber test on tari-dan repo

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify
    BREAKING CHANGE: eviction proof changed

@sdbondi sdbondi force-pushed the jellyfish-tree-evict-proof branch from 94693ed to 92d3606 Compare December 12, 2024 12:34
Copy link

Test Results (CI)

    3 files    135 suites   40m 9s ⏱️
1 352 tests 1 352 ✅ 0 💤 0 ❌
4 054 runs  4 054 ✅ 0 💤 0 ❌

Results for commit 92d3606.

@sdbondi sdbondi marked this pull request as ready for review December 12, 2024 12:55
@sdbondi sdbondi requested a review from a team as a code owner December 12, 2024 12:55
Copy link

Test Results (Integration tests)

 2 files  11 suites   24m 5s ⏱️
36 tests 35 ✅ 0 💤 1 ❌
37 runs  36 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 92d3606.

@sdbondi sdbondi merged commit 0e72c11 into tari-project:feature-dan2 Dec 12, 2024
17 of 18 checks passed
sdbondi added a commit to tari-project/tari-dan that referenced this pull request Dec 12, 2024
Description
---
Adds a JMT implementation to tari_jellyfish crate. Useful for state tree
inclusion proofs. Currently used to validate eviction command commit
proofs


Motivation and Context
---
tari-project/tari#6724

How Has This Been Tested?
---

What process can a PR reviewer use to test or verify this change?
---


Breaking Changes
---

- [ ] None
- [x] Requires data directory to be deleted
- [ ] Other - Please specify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant