feat!: add sidechain eviction proof transaction #6702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-validator-evict
branch
from
d4c5d5a to
2821268
Compare
Test Results (CI) 3 files 132 suites 39m 21s ⏱️ Results for commit 25ca763. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests)36 tests 36 ✅ 14m 57s ⏱️ Results for commit 25ca763. ♻️ This comment has been updated with latest results. |
sdbondi
force-pushed
the
core-validator-evict
branch
2 times, most recently
from
fe794be to
680f4f6
Compare
sdbondi
force-pushed
the
core-validator-evict
branch
from
5317412 to
6269f44
Compare
sdbondi
force-pushed
the
core-validator-evict
branch
2 times, most recently
from
e1000f4 to
7255118
Compare
sdbondi
force-pushed
the
core-validator-evict
branch
from
7255118 to
25ca763
Compare
3 tasks
sdbondi
added a commit
to tari-project/tari-dan
that referenced
this pull request
Dec 11, 2024
Description --- feat!: submit eviction proof for nodes that miss many proposals various bug fixes cucumber that tests end-to-end eviction watcher submits the eviction transaction fixes for epoch manager to allow exits removed suspending and resuming nodes exit consensus and sync if receiving a QC for a future epoch Motivation and Context --- If a node goes offline, consensus will run much more slowly due to having to wait for leader failure each round. This PR implements the eviction command and generation of an eviction proof that can be submitted on L1. Once the epoch is reached where the eviction applies, the validator is removed from the committee. Requires tari-project/tari#6702 Suspending and resuming nodes adds complexity and some bugs were observed. Since evicted nodes are already immediately skipped in rounds by other validator nodes before they are evicted, the value of suspending nodes is limited and it was decided that it was not worth the added complexity. How Has This Been Tested? --- New unit tests and cucumber, manually What process can a PR reviewer use to test or verify this change? --- 1. Run a swarm, 2. run a watcher and let it register 3. mine 10 blocks to allow the watcher vn to start consensus 4. stop a node in swarm 5. wait for eviction proof to be submitted by the watcher 6. mine 10 blocks, observe that the stopped node is no longer part of the committee Breaking Changes --- - [ ] None - [x] Requires data directory to be deleted - [ ] Other - Please specify BREAKING CHANGE: incompatible global and state database changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sidechain eviction proof transaction
validations for eviction proof
only single validator node registration permitted
Motivation and Context
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes