feat: improve mempool error msg when mempool out of sync #6618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved mempool error msg when mempool falls behind the persisted blockchain db
Test Results (CI) 3 files 129 suites 37m 10s ⏱️ Results for commit 1c8f321. |
ghpbot-tari-project
added
P-acks_required
stringhandler
approved these changes
Oct 9, 2024
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
approved these changes
Oct 10, 2024
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 10, 2024
* development: chore(ci): remove ledger nanos and update ledger key gif resources (tari-project#6617) feat: improve mempool error msg when mempool out of sync (tari-project#6618) feat: exit logic for pre-mine spend (tari-project#6615) chore: new release esme v1.6.0-pre.0 (tari-project#6614) feat: enable identity grpc method by default (tari-project#6613) feat: pre-mine introduce temp ban and add counters (tari-project#6612) chore: changes mainnet default network (tari-project#6610) chore(ci): add riscv64 builds and misc script fixes (tari-project#6611) feat!: esme test pre-mine with immediate spend (tari-project#6609) feat!: add context to ffi callbacks (tari-project#6608) feat: add default exclude dial (tari-project#6607) feat!: add input mr into genesis block (tari-project#6601) feat: update pre_mine specification (tari-project#6606)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved mempool error message when mempool falls behind the persisted blockchain db.
Motivation and Context
This error will occur in an edge case when the mempool is in the process of finalizing a block template and just before it is done, a new block has been added to the blockchain db. As the two processes are asynchronous, the resolution implemented in the code is to return an error message so that the client can issue a new request. Meanwhile, the mempool has time to react to the updated blockchain db state.
How Has This Been Tested?
Compile succeed.
What process can a PR reviewer use to test or verify this change?
Code review.
Breaking Changes