-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validator_node): new state store implementation using RocksDB #1192
Draft
mrnaveira
wants to merge
33
commits into
tari-project:development
Choose a base branch
from
mrnaveira:rocksdb
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is still a very early draft
Description
state_store_rocksdb
with a RocksDB implementation of the consensus state store traitsdatabase_type
to choose between"rocksdb"
(default) and"sqlite"
ValidatorNodeStateStore
trait to make all VN creates independent of the database type. It's a provisional workaround as we ideally want to pass around values as something likeBox<dyn StateStore>
, but this requires some redesign of theStateStore
(and related) traits.Motivation and Context
Currently we only have a SQLite implementation of the VN state store. This is fine for development but something like RocksDB should result in a performance improvement.
How Has This Been Tested?
TBD
What process can a PR reviewer use to test or verify this change?
TBD
Breaking Changes