feat(list-tribes): add configurable timeout to list-tribes command #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
Sep 16, 2024
| /// | ||
| /// The list-tribes commands tries to look for all the currently available tribes | ||
| /// for this amount of time maximum. | ||
| #[arg(long, value_name = "timeout", default_value_t = 30)] |
There was a problem hiding this comment.
Let's change this to 15 seconds as a default
There was a problem hiding this comment.
okay, let me change
Merged
via the queue into
tari-project:development
with commit Sep 16, 2024
3a1d0bb
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until now the
list-tribescommand was trying to collect all the tribes within fixed 30 seconds. Now with this change it is configurable via cli using--timeoutwhere you can set the timeout as seconds.Motivation and Context
How Has This Been Tested?
sha_p2pool list-tribes --timeout 5- within 5 seconds it is listing currently known tribes.What process can a PR reviewer use to test or verify this change?
See test.
Breaking Changes