-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MariaDb database connection support #250
Add MariaDb database connection support #250
Conversation
add PomeloDatabaseConnection class for abstraction
Oh no you're perfectly fine. Even though MySQL and MariaDB might share a driver, they are technically two different connection types and could end up having slightly different connection string options or configurations in the future, so keeping them separate works just fine. This is great, thanks! I'll review and get it merged! |
@SimonNyvall I ended up completely separating the MySql and MariaDb connection types and removed the I also removed the Thanks again for the great contributions! |
@tareqimbasher thank you for merging, I will try to keep the adjustments in mind for future contributions. It is a fun project to work on; it just takes a little while to figure out what to adjust hehe. |
Ya I've been meaning to write some documentation on the general structure of the app and guides on how to extend certain functionality but haven't really gotten around to it yet. I'll dedicate some time to that. |
If I can be of any help @tareqimbasher , just send me a message. I can maybe point out the parts of the codebase that I still don't really get, if that would be of any help? :) |
Yes that would be helpful actually. Go ahead and let me know what parts of the codebase you're having trouble with and I'll do my best to explain. That also might help me determine spots that need to be simplified or made more obvious :) |
Sorry for the delay, I tried a lot of different solutions to the problem. I couldn't work out the kinks without adding the MariaDB type to the backend, so this was the best solution I could come up with. I tried to keep MariaDB only in the frontend part, but this caused some issues when copying a database, logos, etc.
I also thought it would be a good idea to sort the DataConnection in
src/Apps/NetPad.Apps.Common/Data/EntityFrameworkCore/DataConnections
into their own directories, but maybe in a later PR so the changes don't clutter the new MariaDB updates.Changes made
TypeScript Classes and Interfaces:
Data Connection View:
Window Updates:
Backend Integration:
Dependency Injection:
Added MariaDb icon to the resource directory.
Updated DataConnectionType enumeration to include MariaDb.