Converting to async - Initial flow #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring unary and streaming responses behaviour
razsinay
approved these changes
May 28, 2024
|
|
||
| ARG BUILD_LOCAL | ||
|
|
||
| COPY requirements.txt test_requirements.txt setup.py README.md ./ |
There was a problem hiding this comment.
Why do we need to copy the README.md?
There was a problem hiding this comment.
Due to the long description in setup.py:
with open("README.md", "r") as fh: long_description = fh.read()
|
|
||
| optional_any = self._wrap_rpc_behavior(continuation(handler_call_details), metrics_wrapper) | ||
| async for obj in behavior(request_or_iterator, servicer_context): |
There was a problem hiding this comment.
I suggest to find a better name for obj
| yield obj | ||
| raise e | ||
|
|
||
| if response_streaming: |
There was a problem hiding this comment.
I am a bit confused with the multiple try/except blocks.
Maybe we can wrap some of the parts in functions?
There was a problem hiding this comment.
Agree - opening an issue for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.