Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floating point values for priority style param #2011

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Conversation

tallytalwar
Copy link
Member

resolves #2010

Copy link
Member

@matteblair matteblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The Android build should be fixed after you rebase/merge master.

My only suggestion is to add a float or function priority somewhere in the default scene so we'll notice if this breaks.

- floating point values for priority will be used soon once
tilezen/vector-datasource#988 lands in
tilzen tiles
@tallytalwar
Copy link
Member Author

Sure, I will add random float priority values right now. But it might make sense to update these when tiles have the collision property set per feature.

- TODO: replace with collision data function when tilezen tiles support
this
@tallytalwar tallytalwar merged commit 5b2f67c into master Jan 23, 2019
@tallytalwar tallytalwar deleted the float-priority branch January 23, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support float values on priority property
2 participants