Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support float values on priority property #2010

Closed
nvkelso opened this issue Jan 18, 2019 · 1 comment · Fixed by #2011
Closed

Support float values on priority property #2010

nvkelso opened this issue Jan 18, 2019 · 1 comment · Fixed by #2011
Assignees

Comments

@nvkelso
Copy link
Member

nvkelso commented Jan 18, 2019

Sister issue to tangrams/tangram#692 on JS side.

Currently the priority property of point and text draw styles only supports ints, but Tangram JS support floats. (Both support functions).

Tilezen is adding a new collision_rank property in v1.7 that we'd like to use along with min_zoom to return a float.

This comment is the tl;dr:

Specifically, this should allow a function like (which returns a float):

priority = feature.properties.min_zoom + (1 - 1 / feature.properties.collision_rank) * 0.1

@nvkelso
Copy link
Member Author

nvkelso commented Jan 18, 2019

/cc @tallytalwar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants