AND-4628 Moved NFC enable check #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sateetas
requested review from
roman-pv,
iiiburnyiii,
Mama1emon,
kozarezvlad and
Yoggam1
as code owners
Mama1emon
previously approved these changes
Oct 24, 2023
roman-pv
reviewed
Oct 25, 2023
| @@ -32,7 +32,7 @@ fun TangemSdk.Companion.init(activity: ComponentActivity, config: Config = Confi | |||
| val secureStorage = SecureStorage.create(activity) | |||
| val nfcManager = TangemSdk.initNfcManager(activity) | |||
|
|
|||
| val viewDelegate = DefaultSessionViewDelegate(nfcManager, nfcManager.reader, activity) | |||
| val viewDelegate = DefaultSessionViewDelegate(nfcManager, activity) | |||
There was a problem hiding this comment.
Ты не подлил изменения конструктора DefaultSessionViewDelegate, на тесты не собирается с ошибкой
# Conflicts: # tangem-sdk-android/src/main/java/com/tangem/sdk/DefaultSessionViewDelegate.kt
roman-pv
previously approved these changes
Nov 17, 2023
kozarezvlad
reviewed
Dec 8, 2023
| @@ -46,6 +46,17 @@ class DefaultSessionViewDelegate( | |||
| ) { | |||
| Log.view { "session started" } | |||
| createAndShowState(SessionViewDelegateState.Ready(formatCardId(cardId)), enableHowTo, message, iconScanRes) | |||
| checkNfcEnabled() | |||
There was a problem hiding this comment.
а если не дал разрешение на nfc то диалог скана так и останется подвешенный?
There was a problem hiding this comment.
ага, помню обсуждали что так ок будет,
иначе много изменений будет в механизме обработки сессии, и в чистоте он потеряет
можно будет сделать отдельной задачей, если сильно понадобится
roman-pv
approved these changes
Dec 8, 2023
kozarezvlad
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.