AND-3723 extra sign on scant bottom sheet #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbixahue
requested review from
lazutkin-andrey,
roman-pv,
iiiburnyiii,
Mama1emon,
kozarezvlad,
Yoggam1 and
Sateetas
as code owners
roman-pv
reviewed
Jul 17, 2023
| tvCard.text = getFormattedString(R.string.cid_format, scannedCardId) | ||
| tvCard.show() | ||
| } else { | ||
| if (scannedCardId == null) { | ||
| tvCard.text = "" |
There was a problem hiding this comment.
тут не нужно то же самое для tvCardId делать? tvCardId.text = ""
roman-pv
approved these changes
Jul 17, 2023
Mama1emon
reviewed
Jul 18, 2023
| @@ -27,6 +27,18 @@ | |||
| android:layout_width="8dp" | |||
| android:layout_height="1dp" /> | |||
|
|
|||
| <TextView | |||
There was a problem hiding this comment.
На ios такая же логика? А то будет потом расхождение в строках?
iiiburnyiii
approved these changes
Jul 19, 2023
kozarezvlad
force-pushed
the
bugifx/AND-3723-extra_sign_on_scant_bottom_sheet
branch
from
aecca7e to
076d75a
Compare
kozarezvlad
deleted the
bugifx/AND-3723-extra_sign_on_scant_bottom_sheet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.