Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for attachment option #472

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

syncblaze
Copy link
Contributor

@syncblaze syncblaze commented Oct 20, 2024

Summary

Checklist

  • I have run nox and all the pipelines have passed.
  • I have created a changelog fragment to describe this change

Related issues

@syncblaze
Copy link
Contributor Author

i have not run nox yet because i just found this bug and fixed it in github web so i will clone the fork tomorrow and run nox

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.63%. Comparing base (65a766d) to head (4abf691).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   53.63%   53.63%           
=======================================
  Files          37       37           
  Lines        2905     2905           
=======================================
  Hits         1558     1558           
  Misses       1347     1347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tandemdude tandemdude merged commit 85fdc86 into tandemdude:master Oct 20, 2024
7 checks passed
@syncblaze syncblaze deleted the bugfix/attachment-option-type branch October 20, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants