Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dependency fallbacks #454

Merged
merged 16 commits into from
Sep 21, 2024
Merged

feat: dependency fallbacks #454

merged 16 commits into from
Sep 21, 2024

Conversation

tandemdude
Copy link
Owner

Summary

Add ability to parse and inject union and optional parameters, including "meta annotations" to modify the injection behaviour for parameters

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 88.76404% with 30 lines in your changes missing coverage. Please review.

Project coverage is 53.59%. Comparing base (0be9542) to head (c23234e).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lightbulb/di/conditions.py 79.77% 18 Missing ⚠️
lightbulb/di/container.py 89.13% 5 Missing ⚠️
lightbulb/client.py 0.00% 4 Missing ⚠️
lightbulb/di/graph.py 98.97% 1 Missing ⚠️
lightbulb/di/registry.py 85.71% 1 Missing ⚠️
lightbulb/loaders.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   51.10%   53.59%   +2.49%     
==========================================
  Files          35       37       +2     
  Lines        2671     2864     +193     
==========================================
+ Hits         1365     1535     +170     
- Misses       1306     1329      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tandemdude tandemdude merged commit dd37a49 into master Sep 21, 2024
9 checks passed
@tandemdude tandemdude deleted the feat/dependency-fallbacks branch September 21, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant