Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace current v2 examples to lightbulb v3 syntax #436

Merged
merged 3 commits into from
Aug 10, 2024

Conversation

st1xkz
Copy link
Contributor

@st1xkz st1xkz commented Aug 9, 2024

Summary

i have updated the current v2 examples to lightbulb v3 as well as deleted redundant example files

Checklist

  • I have run nox and all the pipelines have passed.
  • I have created a changelog fragment to describe this change

Related issues

Copy link
Owner

@tandemdude tandemdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! If you could update the copyright in each file to the new one (copy it from lightbulb/__init__.py) as I relicensed the source using MIT for V3. Just a couple other comments for you to address as well.

examples/moderation_example.py Show resolved Hide resolved
examples/moderation_example.py Outdated Show resolved Hide resolved
examples/in_depth_component_example.py Outdated Show resolved Hide resolved
examples/in_depth_component_example.py Outdated Show resolved Hide resolved
@tandemdude tandemdude merged commit 02ecc00 into tandemdude:master Aug 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants