Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for command localization #399

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Implement support for command localization #399

merged 4 commits into from
Mar 6, 2024

Conversation

tandemdude
Copy link
Owner

No description provided.

null-domain
null-domain requested changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@null-domain null-domain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some good stuff, just a few nitpicks to point out

lightbulb/client.py Outdated Show resolved Hide resolved
lightbulb/client.py Outdated Show resolved Hide resolved
lightbulb/client.py Outdated Show resolved Hide resolved
lightbulb/client.py Outdated Show resolved Hide resolved
lightbulb/commands/commands.py Outdated Show resolved Hide resolved
lightbulb/commands/options.py Outdated Show resolved Hide resolved
lightbulb/commands/options.py Outdated Show resolved Hide resolved
lightbulb/commands/options.py Outdated Show resolved Hide resolved
lightbulb/commands/options.py Show resolved Hide resolved
lightbulb/localization.py Show resolved Hide resolved
@tandemdude tandemdude merged commit 29dfd6f into v3 Mar 6, 2024
6 checks passed
@tandemdude tandemdude deleted the feat/localization branch March 6, 2024 10:37
tandemdude added a commit that referenced this pull request Aug 8, 2024
@tandemdude
Implement support for command localization (#399)
f454824 
* Switch to composition for client class, implement localizations for commands groups and options

* Reimplement localizations

* Add additional documentation

* Address pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@null-domain null-domain null-domain requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tandemdude @null-domain