Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing actions to policy.json #1315

Merged
merged 5 commits into from
Jan 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
"Effect": "Allow",
"Action": [
"apigateway:GET",
"codecommit:ListRepositories",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since #1229

"codecommit:ListTagsForResource",
"codebuild:ListProjects",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since #1216

"codedeploy:ListApplications",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since #1228

"codedeploy:ListDeploymentGroups",
"cloudwatch:GetMetricStatistics",
"cloudfront:ListDistributions",
"cloudfront:ListFunctions",
Expand All @@ -14,6 +19,7 @@
"cloudwatch:ListTagsForResource",
"cloudwatch:ListDashboards",
"cloudwatch:ListMetricStreams",
"dynamodb:DescribeTable",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since #1111

"dynamodb:ListTables",
"sts:GetCallerIdentity",
"dynamodb:ListTagsOfResource",
Expand Down Expand Up @@ -55,6 +61,7 @@
"iam:ListRoles",
"iam:ListSAMLProviders",
"iam:ListSAMLProviderTags",
"iam:ListUsers",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since #991

"kinesis:ListStreams",
"kinesis:ListStreamConsumers",
"kms:ListKeys",
Expand Down Expand Up @@ -83,11 +90,12 @@
"elasticfilesystem:DescribeFileSystems",
"elasticfilesystem:ListTagsForResource",
"iam:ListInstanceProfileTags",
"lambda:ListEventSourceMappings",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since #1040

"lambda:ListFunctions",
"lambda:ListTags",
"es:ListDomainNames",
"es:DescribeDomains",
"s3:ListBucket"
Copy link
Contributor Author

@roblambell roblambell Jan 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This permission is for listing objects/contents of a bucket - AFAIK we don't need it

Grants permission to list some or all of the objects in an Amazon S3 bucket (up to 1000).

https://aws.permissions.cloud/iam/s3#s3-ListBucket

"s3:ListAllMyBuckets"
Copy link
Contributor Author

@roblambell roblambell Jan 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This permission is required for the S3.ListBuckets API method we're using

list all buckets owned by the authenticated sender of the request

https://aws.permissions.cloud/api/s3#S3_ListBuckets

],
"Resource": "*"
}
Expand Down