Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1272 add new group by option in cost explorer #1308

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Feature/1272 add new group by option in cost explorer #1308

merged 6 commits into from
Jan 4, 2024
+40 −6

Conversation

syedbarimanjan
Copy link
Contributor

Added the feature as per #1272

Reviewers

@Azanul

Azanul
Azanul approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-02 at 10 18 40 AM

@Azanul
Copy link
Collaborator

Azanul commented Jan 2, 2024

Good work @syedbarimanjan !!

@syedbarimanjan
Copy link
Contributor Author

@AvineshTripathi

AvineshTripathi
AvineshTripathi approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@AvineshTripathi AvineshTripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with a note that discussion needs to be done about the wording we share

@syedbarimanjan
Copy link
Contributor Author

Approve with a note that discussion needs to be done about the wording we share

didnt get you

@AvineshTripathi
Copy link
Collaborator

@syedbarimanjan its not for you, its for us maintainers to track down the discussions for future

@mlabouardy mlabouardy merged commit 93330f3 into tailwarden:develop Jan 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvineshTripathi AvineshTripathi AvineshTripathi approved these changes

@Azanul Azanul Azanul approved these changes

@mlabouardy mlabouardy mlabouardy approved these changes

@ShubhamPalriwala ShubhamPalriwala Awaiting requested review from ShubhamPalriwala

@greghub greghub Awaiting requested review from greghub

@Traxmaxx Traxmaxx Awaiting requested review from Traxmaxx

@jakepage91 jakepage91 Awaiting requested review from jakepage91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syedbarimanjan @Azanul @AvineshTripathi @mlabouardy