Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Onboarding wizard #1285

Merged
merged 24 commits into from
Jan 8, 2024
Merged

Conversation

Azanul
Copy link
Collaborator

@Azanul Azanul commented Dec 15, 2023

Problem

Unstable onboarding wizard

Solution

Stable onboarding wizard

Changes Made

  • DB creation/selection first then cloud account
  • Added a helper file in handlers folder to circumvent cyclic import issue

Notes

Will refactor to clean code in near future to avoid issues like cyclic import completely without repeating code

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

tanbirali and others added 17 commits December 6, 2023 14:00
update to test mintlify workflow
…Ocean, OCI, Linode, K8s, Tencent (tailwarden#1215)

* making fetching resources parallelized for all providers

Signed-off-by: bishal7679 <[email protected]>

* updating fetching resources for civo and tencent

Signed-off-by: bishal7679 <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>
tailwarden#1143)

* feat: update colors in tailwind config

* fix: update color class-names to match new palette

* fix: update primary & secondary color class-names to match new palette

* fix: update box-shadows to match design system

* fix: update tailwind config and class-names
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>
* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>
* feat: add aws codecommit resource

* chore: remove unused code

* chore: remove commented code

---------

Co-authored-by: amal richwin <[email protected]>
* Migration Nextjs 13 to 14

* fix: next export

* add output export property

---------

Co-authored-by: Azanul Haque <[email protected]>
@Azanul
Copy link
Collaborator Author

Azanul commented Dec 15, 2023

@jakepage91 could you check if the onboarding wizard works for you on this branch.

@jakepage91
Copy link
Contributor

Just did, doesn't seem to be working unfortunately.

@AvineshTripathi
Copy link
Collaborator

ref #1273 for context

@jakepage91
Copy link
Contributor

Hey there @AvineshTripathi I have seen the comment on your other issue, I see that you mention that ENV VARS should be used in the onboarding wizard. Having done this I still can't get the onboarding wizard to work.

Has this worked for either you Avinesh or @Azanul ?

@AvineshTripathi
Copy link
Collaborator

@jakepage91 I beleive you must be getting the weird error right. The problem is with current architecture that is not allowing the wizard to work. we are refactoring it into a new one. Plan of the changes is present in the maintainers channel

@Azanul Azanul marked this pull request as ready for review January 8, 2024 11:18
@Azanul Azanul requested a review from mlabouardy as a code owner January 8, 2024 11:18
Copy link
Contributor

@jakepage91 jakepage91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, working on my end!

@mlabouardy mlabouardy merged commit ef29f84 into tailwarden:develop Jan 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.