Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporarily removing onboarding wizard for updates #1273

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix: temporarily removing onboarding wizard for updates #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76b31a6
fix: temporarily removing onboarding wizard for updates
AvineshTripathi Dec 8, 2023
af03653
Merge branch 'develop' into onboarding-bug
jakepage91 Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dashboard/components/layout/Layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function Layout({ children }: LayoutProps) {
}
}, [telemetry]);

const betaFlagOnboardingWizard = true;
const betaFlagOnboardingWizard = false; // set this to true once wizard gets good support of the backend
const isOnboarding =
betaFlagOnboardingWizard && router.pathname.startsWith('/onboarding');

Expand Down
14 changes: 8 additions & 6 deletions dashboard/components/layout/hooks/useGlobalStats.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,14 @@ function useGlobalStats() {
setError(true);
} else {
setLoading(false);

if (res.accounts === 0) {
setHasNoAccounts(true);
} else {
setData(res);
}
// in the case of res.account === 0 the default view should be shown
// this couples the backend and the frontend strongly
// if (res.accounts === 0) {

// } else {
// setData(res);
// }
setData(res);
}
});
}
Expand Down