Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental loop capture #1252

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Fix accidental loop capture #1252

merged 3 commits into from
Nov 30, 2023

Conversation

Azanul
Copy link
Collaborator

@Azanul Azanul commented Nov 30, 2023

Problem

https://go.dev/blog/loopvar-preview

Solution

Make a copy of the loop var for passing on.

Changes Made

  • Fixed accidental loop capture for all providers
  • A couple chores

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

@Azanul
Copy link
Collaborator Author

Azanul commented Nov 30, 2023

@AvineshTripathi @titanventura Check it out

@Azanul
Copy link
Collaborator Author

Azanul commented Nov 30, 2023

@jakepage91 This was causing the missing Lambda issue we discussed

@jakepage91 jakepage91 self-requested a review November 30, 2023 12:36
@Azanul Azanul merged commit 2bf9167 into tailwarden:develop Nov 30, 2023
4 checks passed
Azanul added a commit to Azanul/komiser that referenced this pull request Dec 6, 2023
* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>
Azanul added a commit that referenced this pull request Dec 6, 2023
* fix(1205): Resource fetching performance improvement for OVH

* Update civo.mdx

update to test mintlify workflow

* fix: Resource fetching performance improvement for Scaleway (#1212)

Co-authored-by: Azanul Haque <[email protected]>

* [KOM-38]: Resource fetching performance improvement for CIVO, DigitalOcean, OCI, Linode, K8s, Tencent (#1215)

* making fetching resources parallelized for all providers

Signed-off-by: bishal7679 <[email protected]>

* updating fetching resources for civo and tencent

Signed-off-by: bishal7679 <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* fix: no OVH in docs (#1218)

Signed-off-by: Azanul <[email protected]>

* Update hello-to-new-contributors.yml

* [FEAT-1092]: Update color names and box-shadows to match Design-System (#1143)

* feat: update colors in tailwind config

* fix: update color class-names to match new palette

* fix: update primary & secondary color class-names to match new palette

* fix: update box-shadows to match design system

* fix: update tailwind config and class-names

* feat: add aws codebuild resource (#1216)

Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* feat: add aws codedeploy resource (#1228)

* Fix accidental loop capture (#1252)

* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>

* feat: add aws codecommit resource (#1229)

* feat: add aws codecommit resource

* chore: remove unused code

* chore: remove commented code

---------

Co-authored-by: amal richwin <[email protected]>

* Check for nil VpcId and SubnetId before use (#1254)

Fixes #1250

Co-authored-by: Azanul Haque <[email protected]>

* Migration Nextjs 13 to 14 (#1217)

* Migration Nextjs 13 to 14

* fix: next export

* add output export property

---------

Co-authored-by: Azanul Haque <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>
Azanul added a commit that referenced this pull request Dec 7, 2023
* fix(1205): Resource fetching performance improvement for OVH

* Update civo.mdx

update to test mintlify workflow

* fix: Resource fetching performance improvement for Scaleway (#1212)

Co-authored-by: Azanul Haque <[email protected]>

* [KOM-38]: Resource fetching performance improvement for CIVO, DigitalOcean, OCI, Linode, K8s, Tencent (#1215)

* making fetching resources parallelized for all providers

Signed-off-by: bishal7679 <[email protected]>

* updating fetching resources for civo and tencent

Signed-off-by: bishal7679 <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* fix: no OVH in docs (#1218)

Signed-off-by: Azanul <[email protected]>

* Update hello-to-new-contributors.yml

* [FEAT-1092]: Update color names and box-shadows to match Design-System (#1143)

* feat: update colors in tailwind config

* fix: update color class-names to match new palette

* fix: update primary & secondary color class-names to match new palette

* fix: update box-shadows to match design system

* fix: update tailwind config and class-names

* feat: add aws codebuild resource (#1216)

Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* feat: add aws codedeploy resource (#1228)

* Fix accidental loop capture (#1252)

* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>

* feat: add aws codecommit resource (#1229)

* feat: add aws codecommit resource

* chore: remove unused code

* chore: remove commented code

---------

Co-authored-by: amal richwin <[email protected]>

* Check for nil VpcId and SubnetId before use (#1254)

Fixes #1250

Co-authored-by: Azanul Haque <[email protected]>

* Migration Nextjs 13 to 14 (#1217)

* Migration Nextjs 13 to 14

* fix: next export

* add output export property

---------

Co-authored-by: Azanul Haque <[email protected]>

* Rebase to master (#1268)

* fix(1205): Resource fetching performance improvement for OVH

* Update civo.mdx

update to test mintlify workflow

* fix: Resource fetching performance improvement for Scaleway (#1212)

Co-authored-by: Azanul Haque <[email protected]>

* [KOM-38]: Resource fetching performance improvement for CIVO, DigitalOcean, OCI, Linode, K8s, Tencent (#1215)

* making fetching resources parallelized for all providers

Signed-off-by: bishal7679 <[email protected]>

* updating fetching resources for civo and tencent

Signed-off-by: bishal7679 <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* fix: no OVH in docs (#1218)

Signed-off-by: Azanul <[email protected]>

* Update hello-to-new-contributors.yml

* [FEAT-1092]: Update color names and box-shadows to match Design-System (#1143)

* feat: update colors in tailwind config

* fix: update color class-names to match new palette

* fix: update primary & secondary color class-names to match new palette

* fix: update box-shadows to match design system

* fix: update tailwind config and class-names

* feat: add aws codebuild resource (#1216)

Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* feat: add aws codedeploy resource (#1228)

* Fix accidental loop capture (#1252)

* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>

* feat: add aws codecommit resource (#1229)

* feat: add aws codecommit resource

* chore: remove unused code

* chore: remove commented code

---------

Co-authored-by: amal richwin <[email protected]>

* Check for nil VpcId and SubnetId before use (#1254)

Fixes #1250

Co-authored-by: Azanul Haque <[email protected]>

* Migration Nextjs 13 to 14 (#1217)

* Migration Nextjs 13 to 14

* fix: next export

* add output export property

---------

Co-authored-by: Azanul Haque <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>

* fix: wrong slack guide url (#1264)

This commit fixes #1259

Signed-off-by: Shikhar Vashistha <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Shikhar Vashistha <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>
Co-authored-by: Shikhar Vashistha <[email protected]>
Azanul added a commit to Azanul/komiser that referenced this pull request Dec 27, 2023
* fix(1205): Resource fetching performance improvement for OVH

* Update civo.mdx

update to test mintlify workflow

* fix: Resource fetching performance improvement for Scaleway (tailwarden#1212)

Co-authored-by: Azanul Haque <[email protected]>

* [KOM-38]: Resource fetching performance improvement for CIVO, DigitalOcean, OCI, Linode, K8s, Tencent (tailwarden#1215)

* making fetching resources parallelized for all providers

Signed-off-by: bishal7679 <[email protected]>

* updating fetching resources for civo and tencent

Signed-off-by: bishal7679 <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* fix: no OVH in docs (tailwarden#1218)

Signed-off-by: Azanul <[email protected]>

* Update hello-to-new-contributors.yml

* [FEAT-1092]: Update color names and box-shadows to match Design-System (tailwarden#1143)

* feat: update colors in tailwind config

* fix: update color class-names to match new palette

* fix: update primary & secondary color class-names to match new palette

* fix: update box-shadows to match design system

* fix: update tailwind config and class-names

* feat: add aws codebuild resource (tailwarden#1216)

Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* feat: add aws codedeploy resource (tailwarden#1228)

* Fix accidental loop capture (tailwarden#1252)

* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>

* feat: add aws codecommit resource (tailwarden#1229)

* feat: add aws codecommit resource

* chore: remove unused code

* chore: remove commented code

---------

Co-authored-by: amal richwin <[email protected]>

* Check for nil VpcId and SubnetId before use (tailwarden#1254)

Fixes tailwarden#1250

Co-authored-by: Azanul Haque <[email protected]>

* Migration Nextjs 13 to 14 (tailwarden#1217)

* Migration Nextjs 13 to 14

* fix: next export

* add output export property

---------

Co-authored-by: Azanul Haque <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>
Azanul added a commit that referenced this pull request Dec 27, 2023
* v3.1.6 release 🚀 (#1265)

* fix(1205): Resource fetching performance improvement for OVH

* Update civo.mdx

update to test mintlify workflow

* fix: Resource fetching performance improvement for Scaleway (#1212)

Co-authored-by: Azanul Haque <[email protected]>

* [KOM-38]: Resource fetching performance improvement for CIVO, DigitalOcean, OCI, Linode, K8s, Tencent (#1215)

* making fetching resources parallelized for all providers

Signed-off-by: bishal7679 <[email protected]>

* updating fetching resources for civo and tencent

Signed-off-by: bishal7679 <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* fix: no OVH in docs (#1218)

Signed-off-by: Azanul <[email protected]>

* Update hello-to-new-contributors.yml

* [FEAT-1092]: Update color names and box-shadows to match Design-System (#1143)

* feat: update colors in tailwind config

* fix: update color class-names to match new palette

* fix: update primary & secondary color class-names to match new palette

* fix: update box-shadows to match design system

* fix: update tailwind config and class-names

* feat: add aws codebuild resource (#1216)

Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* feat: add aws codedeploy resource (#1228)

* Fix accidental loop capture (#1252)

* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>

* feat: add aws codecommit resource (#1229)

* feat: add aws codecommit resource

* chore: remove unused code

* chore: remove commented code

---------

Co-authored-by: amal richwin <[email protected]>

* Check for nil VpcId and SubnetId before use (#1254)

Fixes #1250

Co-authored-by: Azanul Haque <[email protected]>

* Migration Nextjs 13 to 14 (#1217)

* Migration Nextjs 13 to 14

* fix: next export

* add output export property

---------

Co-authored-by: Azanul Haque <[email protected]>

* Rebase to master (#1268)

* fix(1205): Resource fetching performance improvement for OVH

* Update civo.mdx

update to test mintlify workflow

* fix: Resource fetching performance improvement for Scaleway (#1212)

Co-authored-by: Azanul Haque <[email protected]>

* [KOM-38]: Resource fetching performance improvement for CIVO, DigitalOcean, OCI, Linode, K8s, Tencent (#1215)

* making fetching resources parallelized for all providers

Signed-off-by: bishal7679 <[email protected]>

* updating fetching resources for civo and tencent

Signed-off-by: bishal7679 <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* fix: no OVH in docs (#1218)

Signed-off-by: Azanul <[email protected]>

* Update hello-to-new-contributors.yml

* [FEAT-1092]: Update color names and box-shadows to match Design-System (#1143)

* feat: update colors in tailwind config

* fix: update color class-names to match new palette

* fix: update primary & secondary color class-names to match new palette

* fix: update box-shadows to match design system

* fix: update tailwind config and class-names

* feat: add aws codebuild resource (#1216)

Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* feat: add aws codedeploy resource (#1228)

* Fix accidental loop capture (#1252)

* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>

* feat: add aws codecommit resource (#1229)

* feat: add aws codecommit resource

* chore: remove unused code

* chore: remove commented code

---------

Co-authored-by: amal richwin <[email protected]>

* Check for nil VpcId and SubnetId before use (#1254)

Fixes #1250

Co-authored-by: Azanul Haque <[email protected]>

* Migration Nextjs 13 to 14 (#1217)

* Migration Nextjs 13 to 14

* fix: next export

* add output export property

---------

Co-authored-by: Azanul Haque <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>

* fix: wrong slack guide url (#1264)

This commit fixes #1259

Signed-off-by: Shikhar Vashistha <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Shikhar Vashistha <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>
Co-authored-by: Shikhar Vashistha <[email protected]>

* merge: rebase

Signed-off-by: Azanul <[email protected]>

* lint: unused

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Shikhar Vashistha <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>
Co-authored-by: Shikhar Vashistha <[email protected]>
Azanul added a commit that referenced this pull request Dec 28, 2023
* v3.1.6 release 🚀 (#1265)

* fix(1205): Resource fetching performance improvement for OVH

* Update civo.mdx

update to test mintlify workflow

* fix: Resource fetching performance improvement for Scaleway (#1212)

Co-authored-by: Azanul Haque <[email protected]>

* [KOM-38]: Resource fetching performance improvement for CIVO, DigitalOcean, OCI, Linode, K8s, Tencent (#1215)

* making fetching resources parallelized for all providers

Signed-off-by: bishal7679 <[email protected]>

* updating fetching resources for civo and tencent

Signed-off-by: bishal7679 <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* fix: no OVH in docs (#1218)

Signed-off-by: Azanul <[email protected]>

* Update hello-to-new-contributors.yml

* [FEAT-1092]: Update color names and box-shadows to match Design-System (#1143)

* feat: update colors in tailwind config

* fix: update color class-names to match new palette

* fix: update primary & secondary color class-names to match new palette

* fix: update box-shadows to match design system

* fix: update tailwind config and class-names

* feat: add aws codebuild resource (#1216)

Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* feat: add aws codedeploy resource (#1228)

* Fix accidental loop capture (#1252)

* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>

* feat: add aws codecommit resource (#1229)

* feat: add aws codecommit resource

* chore: remove unused code

* chore: remove commented code

---------

Co-authored-by: amal richwin <[email protected]>

* Check for nil VpcId and SubnetId before use (#1254)

Fixes #1250

Co-authored-by: Azanul Haque <[email protected]>

* Migration Nextjs 13 to 14 (#1217)

* Migration Nextjs 13 to 14

* fix: next export

* add output export property

---------

Co-authored-by: Azanul Haque <[email protected]>

* Rebase to master (#1268)

* fix(1205): Resource fetching performance improvement for OVH

* Update civo.mdx

update to test mintlify workflow

* fix: Resource fetching performance improvement for Scaleway (#1212)

Co-authored-by: Azanul Haque <[email protected]>

* [KOM-38]: Resource fetching performance improvement for CIVO, DigitalOcean, OCI, Linode, K8s, Tencent (#1215)

* making fetching resources parallelized for all providers

Signed-off-by: bishal7679 <[email protected]>

* updating fetching resources for civo and tencent

Signed-off-by: bishal7679 <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* fix: no OVH in docs (#1218)

Signed-off-by: Azanul <[email protected]>

* Update hello-to-new-contributors.yml

* [FEAT-1092]: Update color names and box-shadows to match Design-System (#1143)

* feat: update colors in tailwind config

* fix: update color class-names to match new palette

* fix: update primary & secondary color class-names to match new palette

* fix: update box-shadows to match design system

* fix: update tailwind config and class-names

* feat: add aws codebuild resource (#1216)

Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* feat: add aws codedeploy resource (#1228)

* Fix accidental loop capture (#1252)

* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>

* feat: add aws codecommit resource (#1229)

* feat: add aws codecommit resource

* chore: remove unused code

* chore: remove commented code

---------

Co-authored-by: amal richwin <[email protected]>

* Check for nil VpcId and SubnetId before use (#1254)

Fixes #1250

Co-authored-by: Azanul Haque <[email protected]>

* Migration Nextjs 13 to 14 (#1217)

* Migration Nextjs 13 to 14

* fix: next export

* add output export property

---------

Co-authored-by: Azanul Haque <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>

* fix: wrong slack guide url (#1264)

This commit fixes #1259

Signed-off-by: Shikhar Vashistha <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Shikhar Vashistha <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>
Co-authored-by: Shikhar Vashistha <[email protected]>

* merge: rebase

Signed-off-by: Azanul <[email protected]>

* lint: unused

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Shikhar Vashistha <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>
Co-authored-by: Shikhar Vashistha <[email protected]>
Azanul added a commit that referenced this pull request Dec 28, 2023
* fix(1205): Resource fetching performance improvement for OVH

* Update civo.mdx

update to test mintlify workflow

* fix: Resource fetching performance improvement for Scaleway (#1212)

Co-authored-by: Azanul Haque <[email protected]>

* [KOM-38]: Resource fetching performance improvement for CIVO, DigitalOcean, OCI, Linode, K8s, Tencent (#1215)

* making fetching resources parallelized for all providers

Signed-off-by: bishal7679 <[email protected]>

* updating fetching resources for civo and tencent

Signed-off-by: bishal7679 <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* fix: no OVH in docs (#1218)

Signed-off-by: Azanul <[email protected]>

* Update hello-to-new-contributors.yml

* [FEAT-1092]: Update color names and box-shadows to match Design-System (#1143)

* feat: update colors in tailwind config

* fix: update color class-names to match new palette

* fix: update primary & secondary color class-names to match new palette

* fix: update box-shadows to match design system

* fix: update tailwind config and class-names

* feat: add aws codebuild resource (#1216)

Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* feat: add aws codedeploy resource (#1228)

* Fix accidental loop capture (#1252)

* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>

* feat: add aws codecommit resource (#1229)

* feat: add aws codecommit resource

* chore: remove unused code

* chore: remove commented code

---------

Co-authored-by: amal richwin <[email protected]>

* Check for nil VpcId and SubnetId before use (#1254)

Fixes #1250

Co-authored-by: Azanul Haque <[email protected]>

* Migration Nextjs 13 to 14 (#1217)

* Migration Nextjs 13 to 14

* fix: next export

* add output export property

---------

Co-authored-by: Azanul Haque <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>
Azanul added a commit that referenced this pull request Dec 28, 2023
* v3.1.6 release 🚀 (#1265)

* fix(1205): Resource fetching performance improvement for OVH

* Update civo.mdx

update to test mintlify workflow

* fix: Resource fetching performance improvement for Scaleway (#1212)

Co-authored-by: Azanul Haque <[email protected]>

* [KOM-38]: Resource fetching performance improvement for CIVO, DigitalOcean, OCI, Linode, K8s, Tencent (#1215)

* making fetching resources parallelized for all providers

Signed-off-by: bishal7679 <[email protected]>

* updating fetching resources for civo and tencent

Signed-off-by: bishal7679 <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* fix: no OVH in docs (#1218)

Signed-off-by: Azanul <[email protected]>

* Update hello-to-new-contributors.yml

* [FEAT-1092]: Update color names and box-shadows to match Design-System (#1143)

* feat: update colors in tailwind config

* fix: update color class-names to match new palette

* fix: update primary & secondary color class-names to match new palette

* fix: update box-shadows to match design system

* fix: update tailwind config and class-names

* feat: add aws codebuild resource (#1216)

Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* feat: add aws codedeploy resource (#1228)

* Fix accidental loop capture (#1252)

* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>

* feat: add aws codecommit resource (#1229)

* feat: add aws codecommit resource

* chore: remove unused code

* chore: remove commented code

---------

Co-authored-by: amal richwin <[email protected]>

* Check for nil VpcId and SubnetId before use (#1254)

Fixes #1250

Co-authored-by: Azanul Haque <[email protected]>

* Migration Nextjs 13 to 14 (#1217)

* Migration Nextjs 13 to 14

* fix: next export

* add output export property

---------

Co-authored-by: Azanul Haque <[email protected]>

* Rebase to master (#1268)

* fix(1205): Resource fetching performance improvement for OVH

* Update civo.mdx

update to test mintlify workflow

* fix: Resource fetching performance improvement for Scaleway (#1212)

Co-authored-by: Azanul Haque <[email protected]>

* [KOM-38]: Resource fetching performance improvement for CIVO, DigitalOcean, OCI, Linode, K8s, Tencent (#1215)

* making fetching resources parallelized for all providers

Signed-off-by: bishal7679 <[email protected]>

* updating fetching resources for civo and tencent

Signed-off-by: bishal7679 <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* fix: no OVH in docs (#1218)

Signed-off-by: Azanul <[email protected]>

* Update hello-to-new-contributors.yml

* [FEAT-1092]: Update color names and box-shadows to match Design-System (#1143)

* feat: update colors in tailwind config

* fix: update color class-names to match new palette

* fix: update primary & secondary color class-names to match new palette

* fix: update box-shadows to match design system

* fix: update tailwind config and class-names

* feat: add aws codebuild resource (#1216)

Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Azanul Haque <[email protected]>

* feat: add aws codedeploy resource (#1228)

* Fix accidental loop capture (#1252)

* chore: remove dot import

Signed-off-by: Azanul <[email protected]>

* fix: capture of the loop variable

Signed-off-by: Azanul <[email protected]>

* chore: remove duplicate import

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: Azanul <[email protected]>

* feat: add aws codecommit resource (#1229)

* feat: add aws codecommit resource

* chore: remove unused code

* chore: remove commented code

---------

Co-authored-by: amal richwin <[email protected]>

* Check for nil VpcId and SubnetId before use (#1254)

Fixes #1250

Co-authored-by: Azanul Haque <[email protected]>

* Migration Nextjs 13 to 14 (#1217)

* Migration Nextjs 13 to 14

* fix: next export

* add output export property

---------

Co-authored-by: Azanul Haque <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>

* fix: wrong slack guide url (#1264)

This commit fixes #1259

Signed-off-by: Shikhar Vashistha <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Shikhar Vashistha <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>
Co-authored-by: Shikhar Vashistha <[email protected]>

* merge: rebase

Signed-off-by: Azanul <[email protected]>

* lint: unused

Signed-off-by: Azanul <[email protected]>

---------

Signed-off-by: bishal7679 <[email protected]>
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Shikhar Vashistha <[email protected]>
Co-authored-by: tanbirali <[email protected]>
Co-authored-by: LABOUARDY Mohamed <[email protected]>
Co-authored-by: Jake Page <[email protected]>
Co-authored-by: Tanbir Ali <[email protected]>
Co-authored-by: Bishal Das <[email protected]>
Co-authored-by: Avinesh Tripathi <[email protected]>
Co-authored-by: Umar Abid <[email protected]>
Co-authored-by: Richwin <[email protected]>
Co-authored-by: amal richwin <[email protected]>
Co-authored-by: Vanshul Bhatia <[email protected]>
Co-authored-by: Josh VanderLinden <[email protected]>
Co-authored-by: Shivam Sharma <[email protected]>
Co-authored-by: Shikhar Vashistha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants