[FEAT-778] Calculate cost for GCP Redis instances #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: titanventura <[email protected]>
titanventura
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi,
greghub and
Traxmaxx
as code owners
Azanul
requested changes
Nov 28, 2023
providers/gcp/redis/instances.go
Outdated
| } | ||
|
|
||
| func getStartTime(createTime, now time.Time) time.Time { | ||
| firstOfCurrentMonth := time.Date(now.Year(), now.Month(), 1, 0, 0, 0, 0, now.Location()) |
There was a problem hiding this comment.
Could you check with other places in the code and see if this is the same? I think we use UTC time.
Also, it'd be great if we had a util function for doing this repetitive task, since we do it across all the providers.
…etching into a function Signed-off-by: titanventura <[email protected]>
Azanul
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #778
Problem
Currently the cost for GCP redis instances are not calculated.
Changes Made
Notes
Need to test with actual GCP account
Checklist
Reviewers
@jakepage91 @mlabouardy