Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devcontainer): devcontainer setup #1086

Merged
merged 2 commits into from
Oct 15, 2023
Merged

feat(devcontainer): devcontainer setup #1086

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49e3335
feat(devcontainer): devcontainer setup
Azanul Oct 12, 2023
dc19453
Merge branch 'develop' into develop
Azanul Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/go
{
"name": "Go",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should name it something general

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to suggest names

// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/go:1-1.21-bullseye",
"features": {
"ghcr.io/devcontainers-contrib/features/node-asdf:0": {},
"ghcr.io/devcontainers-contrib/features/typescript:2": {}
},
"customizations": {
"vscode": {
"extensions": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about those who use a non-vscode env ;) Like me

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config works with GH Codespaces and VSCode with devcontainers extension. If you use something that has devcontainer support then it'll probably have it's own customizations. Jetbrains has a guide to it.
If you doubt that vscode extensions part might interfere with the spawning devcontainer, I don't think it will but you're welcome to test it out.

What do you use?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point from @AvineshTripathi. I'm on SublimeText and nvim.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that neovim has devcontainer support, don't know if SublimeText does or not.
As I said, the respective tools will have their own customizations. I know how to mention the same for vscode & codespaces but not for other tools.

"golang.go-nightly",
"bradlc.vscode-tailwindcss"
]
}
}

// Features to add to the dev container. More info: https://containers.dev/features.
// "features": {},

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
// "postCreateCommand": "go version",

// Configure tool-specific properties.
// "customizations": {},

// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
}