feat: concurrent resource fetching per provider #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titanventura
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi,
greghub and
Traxmaxx
as code owners
titanventura
changed the title
mlabouardy
reviewed
Oct 15, 2023
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Azanul <[email protected]>
|
Before: f2326e9
After: 1d46d1d
Tested on M2 Pro with no CPU limit and 10GB RAM limit |
Azanul
approved these changes
Oct 15, 2023
mlabouardy
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Template to fetch resources concurrently using worker pools. Implements concurrency for aws fetcher.
Fixes #1014 partially
Changes Made
Notes
Perf test needed
Checklist
Reviewers
@Azanul @AvineshTripathi @mlabouardy @jakepage91