Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Kinesis Data Streams to the list of supported resources #1044

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Adding Kinesis Data Streams to the list of supported resources #1044

merged 1 commit into from
Oct 6, 2023

Conversation

jbleduigou
Copy link
Contributor

@jbleduigou jbleduigou commented Oct 5, 2023 •
edited
Loading

Problem

This PR is about the following feature:
#548

Solution

As far as I can see Kinesis Data Streams are already supported.
The only missing part was having it documented in the supported resources.

Changes Made

  • Only updated the documentation to add KDS to the list of supported resources.

How to Test

I tested by creating a Kinesis Data Stream in my AWS account.
Komiser was able to find it and display it.

Screenshots

image

Notes

n/a

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@jakepage91

@jbleduigou jbleduigou requested a review from jakepage91 as a code owner October 5, 2023 18:51
mlabouardy
mlabouardy approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back @jbleduigou :) LGTM!

@mlabouardy mlabouardy modified the milestones: v3.1.1, v3.1.2 Oct 6, 2023
@mlabouardy mlabouardy added the docs label Oct 6, 2023
@mlabouardy mlabouardy merged commit 5b4c2e4 into tailwarden:develop Oct 6, 2023
@jbleduigou jbleduigou deleted the feature/548-kinesis-data-streams branch October 23, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

@jakepage91 jakepage91 Awaiting requested review from jakepage91

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jbleduigou @mlabouardy