Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support k8s nodes #1041

Merged
merged 2 commits into from
Oct 5, 2023
Merged

feat: support k8s nodes #1041

merged 2 commits into from
Oct 5, 2023

Conversation

asamirr
Copy link
Contributor

@asamirr asamirr commented Oct 4, 2023 •
edited by Azanul
Loading

Problem

Calculating costs for kubernetes nodes was yet to be added.

Solution

Adding support for kubernetes nodes cost calculation.

Changes Made

  • Added a new nodes.go file to the kubernetes provider.

Notes

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

@asamirr asamirr changed the title Feature/support k8s nodes feat: support k8s nodes Oct 4, 2023
Azanul
Azanul approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! @asamirr

ShubhamPalriwala
ShubhamPalriwala approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mlabouardy mlabouardy added this to the v3.1.2 milestone Oct 5, 2023
@mlabouardy mlabouardy merged commit d353dde into tailwarden:develop Oct 5, 2023
2 of 3 checks passed
@asamirr asamirr deleted the feature/support-k8s-nodes branch October 5, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShubhamPalriwala ShubhamPalriwala ShubhamPalriwala approved these changes

@Azanul Azanul Azanul approved these changes

@mlabouardy mlabouardy mlabouardy approved these changes

@AvineshTripathi AvineshTripathi Awaiting requested review from AvineshTripathi AvineshTripathi is a code owner

@greghub greghub Awaiting requested review from greghub

@Traxmaxx Traxmaxx Awaiting requested review from Traxmaxx

Assignees
No one assigned
Labels
kubernetes
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging this pull request may close these issues.

Add support for Kubernetes nodes + cost calculation
4 participants
@asamirr @mlabouardy @Azanul @ShubhamPalriwala