[Feature] Enhancing the Contributing Guide #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepage91
suggested changes
Oct 4, 2023
There was a problem hiding this comment.
Hey there @verma-kunal great work here! I've added a few thoughts
| ``` | ||
| 6. While submitting Pull Request, **make sure to change the base branch from**: [master](https://github.com/tailwarden/komiser/tree/master) to [develop](v). This will ensure to keep your Pull Request away from any conflicts! | ||
|
|
||
| > ### Keeping your Fork Up-to-Date |
There was a problem hiding this comment.
Is there is a reason for this whole section to be quoted?
There was a problem hiding this comment.
the main reason was to highlight this part actually! because merge conflicts can be confusing especially for beginners, so keeping the fork up to date, before committing new changes is always a good practice and prevents merge conflicts
what do you think?
|
thanks for the suggestions @jakepage91 ! All resolved ✅ |
mlabouardy
approved these changes
Oct 5, 2023
|
Thanks @mlabouardy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the existing contributing guide has been revamped with the focus on guiding new contributors on the right path to get involved in the Komiser project!
Few noticeable items added:
Reviewers
@jakepage91 @AvineshTripathi
Fixes #1029