-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: new ci draft release #905
Closed
alankritdabral
wants to merge
37
commits into
tailcallhq:main
from
alankritdabral:chore/new-ci-for-draft-release
Closed
chore: new ci draft release #905
alankritdabral
wants to merge
37
commits into
tailcallhq:main
from
alankritdabral:chore/new-ci-for-draft-release
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: reusee workflow
Revert "feat: reusee workflow"
chore: text
github-actions
bot
added
the
type: feature
Brand new functionality, features, pages, workflows, endpoints, etc.
label
Jan 8, 2024
github-actions
bot
added
the
type: chore
Routine tasks like conversions, reorganization, and maintenance work.
label
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: chore
Routine tasks like conversions, reorganization, and maintenance work.
type: feature
Brand new functionality, features, pages, workflows, endpoints, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As we use
autolabeler
indraft-release
we need to run the draft-release job on pull_request_target in ci.ymlBut this also triggers other jobs(although they get skipped ) in ci.yml
I have tried a better approach :
if: (github.event_name == 'push' && github.ref == 'refs/heads/main') || (github.event_name == 'release' && github.event.action == 'published')
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>