Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use jit engine to handle REST API #3225

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Dec 20, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
#3128

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added ci: benchmark Runs benchmarks type: chore Routine tasks like conversions, reorganization, and maintenance work. labels Dec 20, 2024
@meskill meskill changed the title Chore/remove async graphql engine rest refactor: use jit engine to handle REST API Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.39%. Comparing base (e3a6026) to head (d0b5ce6).

Files with missing lines Patch % Lines
src/core/jit/error.rs 0.00% 3 Missing ⚠️
src/core/rest/partial_request.rs 87.50% 2 Missing ⚠️
src/core/jit/graphql_executor.rs 97.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3225      +/-   ##
==========================================
+ Coverage   86.32%   86.39%   +0.06%     
==========================================
  Files         282      282              
  Lines       28798    28825      +27     
==========================================
+ Hits        24860    24903      +43     
+ Misses       3938     3922      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 20, 2024

🐰 Bencher Report

Branchchore/remove-async-graphql-engine-rest
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
from_json_bench📈 view plot
🚷 view threshold
6,168,800.00
(-0.52%)
6,872,644.27
(89.76%)
group_by📈 view plot
🚷 view threshold
476.43
(-2.01%)
545.97
(87.26%)
input/args.missing📈 view plot
🚷 view threshold
22.32
(-7.16%)
29.13
(76.64%)
input/args.nested.existing📈 view plot
🚷 view threshold
42.78
(-2.61%)
50.14
(85.31%)
input/args.nested.missing📈 view plot
🚷 view threshold
36.29
(-3.28%)
43.77
(82.90%)
input/args.root📈 view plot
🚷 view threshold
37.55
(-5.20%)
45.23
(83.01%)
input/headers.existing📈 view plot
🚷 view threshold
33.04
(+4.49%)
35.44
(93.21%)
input/headers.missing📈 view plot
🚷 view threshold
31.80
(+3.02%)
35.12
(90.56%)
input/value.missing📈 view plot
🚷 view threshold
22.16
(-4.31%)
26.03
(85.16%)
input/value.nested.existing📈 view plot
🚷 view threshold
41.69
(-2.24%)
47.86
(87.09%)
input/value.nested.missing📈 view plot
🚷 view threshold
35.81
(-0.84%)
41.39
(86.50%)
input/value.root📈 view plot
🚷 view threshold
37.85
(-3.44%)
44.36
(85.31%)
input/vars.existing📈 view plot
🚷 view threshold
8.41
(+3.35%)
9.60
(87.57%)
input/vars.missing📈 view plot
🚷 view threshold
11.25
(+8.14%)
13.51
(83.26%)
synth_nested📈 view plot
🚷 view threshold
101,440.00
(-16.66%)
158,678.49
(63.93%)
synth_nested_borrow📈 view plot
🚷 view threshold
37,821.00
(-44.02%)
111,172.02
(34.02%)
test_batched_body📈 view plot
🚷 view threshold
1,913.80
(+1.24%)
2,087.71
(91.67%)
test_batched_body #2📈 view plot
🚷 view threshold
1,532,900.00
(+0.94%)
1,677,838.58
(91.36%)
test_data_loader📈 view plot
🚷 view threshold
395,870.00
(-0.45%)
430,689.32
(91.92%)
test_handle_request📈 view plot
🚷 view threshold
55,995.00
(-56.50%)
153,701.77
(36.43%)
test_handle_request_jit📈 view plot
🚷 view threshold
56,505.00
(-38.35%)
153,670.65
(36.77%)
test_http_execute_method📈 view plot
🚷 view threshold
14,971.00
(+3.23%)
16,218.00
(92.31%)
with_mustache_expressions📈 view plot
🚷 view threshold
1,028.30
(-6.34%)
1,256.83
(81.82%)
with_mustache_literal📈 view plot
🚷 view threshold
636.81
(-9.02%)
811.20
(78.50%)
🐰 View full continuous benchmarking report in Bencher

@meskill meskill marked this pull request as ready for review December 20, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants