Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support gRPC with connect-rpc #3197

Merged
merged 18 commits into from
Dec 5, 2024
Merged

feat: support gRPC with connect-rpc #3197

merged 18 commits into from
Dec 5, 2024

Conversation

laststylebender14
Copy link
Contributor

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 99.35484% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (607d52f) to head (89f9d6c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/core/generator/proto/connect_rpc.rs 99.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3197      +/-   ##
==========================================
+ Coverage   86.66%   86.73%   +0.06%     
==========================================
  Files         277      278       +1     
  Lines       27761    27909     +148     
==========================================
+ Hits        24059    24206     +147     
- Misses       3702     3703       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laststylebender14 laststylebender14 changed the title POC: support gRPC with connect-rpc feat: support gRPC with connect-rpc Dec 5, 2024
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Dec 5, 2024
@tusharmath tusharmath enabled auto-merge (squash) December 5, 2024 07:53
@tusharmath tusharmath disabled auto-merge December 5, 2024 08:00
@tusharmath tusharmath merged commit 51ebc1f into main Dec 5, 2024
28 of 29 checks passed
@tusharmath tusharmath deleted the poc/connect-rpc branch December 5, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants