Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2720): Add Validation for Input Types in gRPC #3181

Closed
wants to merge 2 commits into from

Conversation

HarshMN2345
Copy link

@HarshMN2345 HarshMN2345 commented Dec 1, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #2720
/claim #2720

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

Copy link

algora-pbc bot commented Dec 1, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Dec 1, 2024
@HarshMN2345 HarshMN2345 changed the title feat: Add Validation for Input Types in gRPC (#2720) feat(2720): Add Validation for Input Types in gRPC Dec 1, 2024
@tusharmath
Copy link
Contributor

Hey @HarshMN2345! Thank you for your contribution to Tailcall 🙏

Unfortunately, we cannot merge this PR as the changes proposed do not align with the requirements in the linked issue. I encourage you to review once again and open a new PR with the required changes.

Thank you for your understanding 🙌

@tusharmath tusharmath closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add validation for input types in gRPC
2 participants