This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Literal: Support B'…' string format
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A binary string starts with `b` but `B` is also valid and has the same effect.
| @@ -239,7 +239,7 @@ fn string_single_quoted(input: &[u8]) -> Result<&[u8], Literal> { | |||
| return Result::Error(Error::Code(ErrorKind::Custom(StringError::TooShort as u32))); | |||
| } | |||
|
|
|||
| if input[0] == 'b' as u8 { | |||
| if input[0] == 'b' as u8 || input[0] == 'B' as u8 { | |||
There was a problem hiding this comment.
Wouldn't it be best to consolidate the binary string handling logic instead of having duplicated code between the single-quote and the nowdoc variants?
There was a problem hiding this comment.
Only this condition is similar. The minimum required heuristic length is different.
This is likely to change when we will support string interpolation (see #3).
Do you see any easy factorisation?
There was a problem hiding this comment.
Whoops! I just thought of chaining the check with the parser (binary_check -> string|nowdoc), but I didn't notice those were different. Sorry!
There was a problem hiding this comment.
That's OK :-). Thanks for being attentive!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #43.
Progression
bbutBis also valid and has the same effect,borB).