Typos n clippy #361
Merged
Typos n clippy #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: redundant closure
--> src/xlsx.rs:383:37
|
383 | .filter_map(|a| a.ok())
| ^^^^^^^^^^ help: replace the closure with the method itself: `std::result::Result::ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls
warning: this argument is passed by value, but not consumed in the function body
--> src/xlsb.rs:380:51
|
380 | fn worksheet_range_from_path(&mut self, path: String) -> Result<Range<DataType>, XlsbError> {
| ^^^^^^ help: consider changing the type to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`
warning: unnecessary `!=` operation
--> src/xls.rs:1323:5
|
1323 | / if stack.len() != 1 {
1324 | | Err(XlsError::InvalidFormula {
1325 | | stack_size: stack.len(),
1326 | | })
1327 | | } else {
1328 | | Ok(formula)
1329 | | }
| |_____^
|
= help: change to `==` and swap the blocks of the `if`/`else`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else
= note: `-W clippy::if-not-else` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::if_not_else)]`
warning: unnecessary `!=` operation
--> src/xlsb.rs:1082:5
|
1082 | / if stack.len() != 1 {
1083 | | Err(XlsbError::StackLen)
1084 | | } else {
1085 | | Ok(formula)
1086 | | }
| |_____^
|
= help: change to `==` and swap the blocks of the `if`/`else`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else
warning: unnecessary boolean `not` operation
--> src/de.rs:395:9
|
395 | / if !self.has_headers() {
396 | | visitor.visit_seq(self)
397 | | } else {
398 | | visitor.visit_map(self)
399 | | }
| |_________^
|
= help: remove the `!` and swap the blocks of the `if`/`else`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else
warning: unnecessary boolean `not` operation
--> src/de.rs:408:9
|
408 | / if !self.has_headers() {
409 | | visitor.visit_seq(self)
410 | | } else {
411 | | visitor.visit_map(self)
412 | | }
| |_________^
|
= help: remove the `!` and swap the blocks of the `if`/`else`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.