-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CURLOPT_COOKIELIST
support
#455
Conversation
Add `CURLOPT_COOKIELIST` support
Thanks for adding this and agreed with approach would probably like more things to just be handled through the simpler set/get approach. Do you think it would be possible to add to this a test case? |
Sure, gonna take some time, though. Are you OK wit httpbin usage in the test? |
httpbin looks interesting, but we have TestServlet already in the test_helper I assume for testing if cookies are set you could add a new endpoint:
Maybe something like:
|
Added tests. Looks like Can you please release a new version after this is merged? |
Thanks this is great ! |
@taf2 can you please release a new version? |
Add interface to call
curl_easy_setopt
-Easy::setopt
- withCURLOPT_COOKIELIST
.It's not something like
#cookielist=
, because I believe this method should be more Rubyish, like add constants for special values, support array argument, or even useCURB_OBJECT_HSETTER
instead of simply passing it to libcurl and keep it consistent with other options (like you do this withheaders=
/CURLOPT_HTTPHEADER
, for example, and setenable_cookies
flag accordingly). All of this requires much more effort, and I'm happy with this simple raw interface.