Fixed Some Runtime Issues #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the tool with no config specified, the std default derive would not use serde defaults. This has been alleviated by implementing Default manually. In Schema mode, when files are not produced, like input_objects.rs, the mod.rs still included them in the imports. As far as I can tell, the code is already prepared to return false when this happens, so I just removed the hardcoded true that was there, as that would override the file creation bool as true regardless of what the function reported. Finally, I updated all the dependencies in the main project. I didn't get around to updating the dependencies in the examples however.
dasanibroto
force-pushed
the
fix_no_config_and_dependencies
branch
from
9a90c48 to
8542847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the tool with no config specified, the std default derive would not use serde deserialisation defaults. This has been alleviated by implementing Default manually.
In Schema mode, when files are not produced, like input_objects.rs, the mod.rs still included them in the imports. As far as I can tell, the code is already prepared to return false when this happens, so I just removed the hardcoded true that was there, as that would override the file creation bool as true regardless of what the function reported.
Finally, I updated all the dependencies in the main project. I didn't get around to updating the dependencies in the examples however.
I don't believe I've broken any functionality with these changes, it seems to generate correct code for my schema. I was always trying to use the tool without a config file, as it was declared as optional, which is why I came across these problems.