Refactors wallet handling to allow for adapters. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesduncombe
force-pushed
the
features/refactors-wallet-handling
branch
from
76d791d to
a86fa66
Compare
jamesduncombe
added
enhancement
jamesduncombe
changed the title
jamesduncombe
force-pushed
the
features/refactors-wallet-handling
branch
2 times, most recently
from
a770c10 to
1944254
Compare
jamesduncombe
force-pushed
the
features/refactors-wallet-handling
branch
12 times, most recently
from
e318d11 to
e51e52c
Compare
jamesduncombe
force-pushed
the
features/refactors-wallet-handling
branch
from
b078120 to
8b20d35
Compare
jamesduncombe
force-pushed
the
features/refactors-wallet-handling
branch
from
8b20d35 to
81e266b
Compare
jamesduncombe
force-pushed
the
features/refactors-wallet-handling
branch
from
902f87f to
bd8e1ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Housekeeping 🛠️
Wallet handling
TTEth.Walletso that it can handle multiple adapters.TTEth.Behaviours.Walletfor wallet adapters:new/1- Builds needed attributes to initialise the underlying adapter.wallet_attrs/2: Given a wallet adapter and map return public wallet attributes (public key etc).sign/2: Given a wallet adapter and and hash, return a signature.