Features: Adds cap to investment drawdowns. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #9318: Investment drawdowns: Add cap to smart contract. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 79.77% 80.01% +0.24%
==========================================
Files 56 56
Lines 1132 1136 +4
Branches 178 235 +57
==========================================
+ Hits 903 909 +6
+ Misses 229 227 -2 ☔ View full report in Codecov by Sentry. |
jamesduncombe
force-pushed
the
features/sc-9318-investment-drawdowns-add-cap-to-smart-contract
branch
3 times, most recently
from
22854d8 to
1ed48db
Compare
jamesduncombe
commented
Feb 19, 2024
| @@ -14,7 +14,7 @@ import { abiStructToObj } from "../utils"; | |||
| chai.use(solidity); | |||
| chai.use(smock.matchers); | |||
|
|
|||
| describe.only("MarketplaceFastDeploymentRequestsFacet", () => { | |||
| describe("MarketplaceFastDeploymentRequestsFacet", () => { | |||
There was a problem hiding this comment.
We should probably add a check to the CI for this... easy to sneak this in then not test everything by mistake.
jamesduncombe
force-pushed
the
features/sc-9318-investment-drawdowns-add-cap-to-smart-contract
branch
2 times, most recently
from
f3830f5 to
675321a
Compare
jamesduncombe
commented
Mar 4, 2024
| } | ||
|
|
||
| /// @notice A version identifier for us to track what's deployed. | ||
| uint16 public constant VERSION = 2; | ||
| uint16 public constant VERSION = 3; |
There was a problem hiding this comment.
New feature... version bump.
There was a problem hiding this comment.
Frontend is going to run into some pain here. We should chat.
There was a problem hiding this comment.
Damn, ok. I'll ping you 👍
hickscorp
approved these changes
Mar 6, 2024
jamesduncombe
force-pushed
the
features/sc-9318-investment-drawdowns-add-cap-to-smart-contract
branch
from
675321a to
0744576
Compare
jamesduncombe
force-pushed
the
features/sc-9318-investment-drawdowns-add-cap-to-smart-contract
branch
from
0744576 to
83732e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
capto the creation params for a Crowdfund.isCappedhelper method to Crowdfund contract.