Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features: Gasless transactions ops #91

Merged
merged 12 commits into from
Apr 4, 2024

Conversation

jamesduncombe
Copy link
Contributor

@jamesduncombe jamesduncombe commented Feb 14, 2024

This PR:

Copy link

This pull request has been linked to Shortcut Story #9185: Gasless transactions.

@jamesduncombe jamesduncombe changed the title Gasless transactions ops Features: Gasless transactions ops Feb 14, 2024
@jamesduncombe jamesduncombe added the enhancement New feature or request label Feb 14, 2024
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions-ops branch 5 times, most recently from 0e38840 to 3f62f2d Compare February 14, 2024 11:51
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 91.79104% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 79.03%. Comparing base (fd3cf39) to head (d6a8a4e).
Report is 38 commits behind head on main.

❗ Current head d6a8a4e differs from pull request most recent head 90c4db0. Consider uploading reports for the commit 90c4db0 to get more accurate results

Files Patch % Lines
contracts/common/AHasContext.sol 55.55% 4 Missing ⚠️
contracts/common/AHasGovernors.sol 50.00% 2 Missing ⚠️
contracts/fast/FastForwardableFacet.sol 0.00% 2 Missing ⚠️
contracts/paymaster/PaymasterTopFacet.sol 95.65% 2 Missing ⚠️
contracts/common/AHasForwarder.sol 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #91       +/-   ##
==========================================
+ Coverage   7.52%   79.03%   +71.50%     
==========================================
  Files         47       56        +9     
  Lines        797     1116      +319     
  Branches     210      178       -32     
==========================================
+ Hits          60      882      +822     
+ Misses       737      234      -503     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions-ops branch from 3f62f2d to 49c5b6c Compare February 14, 2024 12:25
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions branch from 8b96a43 to 0003764 Compare February 21, 2024 16:40
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions-ops branch from 49c5b6c to 1cdbdc7 Compare February 21, 2024 16:41
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions-ops branch 4 times, most recently from dd35be8 to 338bbe8 Compare March 5, 2024 13:46
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions branch from c20cb72 to 9cb0bc2 Compare March 5, 2024 14:02
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions-ops branch from 338bbe8 to c10a1ef Compare March 5, 2024 14:02
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions branch from 9cb0bc2 to e766cf8 Compare March 5, 2024 14:09
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions-ops branch from c10a1ef to 1ca5485 Compare March 5, 2024 14:09
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions branch from e766cf8 to 618d4eb Compare March 5, 2024 14:13
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions-ops branch from 1ca5485 to 5e40b8a Compare March 5, 2024 14:13
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions-ops branch from 03ab3f4 to 65e984c Compare March 13, 2024 12:06
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions-ops branch from a748a0f to 2d2c7a2 Compare April 3, 2024 09:29
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions branch from 618d4eb to bdaf271 Compare April 3, 2024 09:29
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions-ops branch 2 times, most recently from ef7ae1d to d6a8a4e Compare April 4, 2024 10:09
Base automatically changed from features/sc-9185-gasless-transactions to main April 4, 2024 13:38
@jamesduncombe jamesduncombe force-pushed the features/sc-9185-gasless-transactions-ops branch from 36d4342 to 90c4db0 Compare April 4, 2024 13:39
@jamesduncombe jamesduncombe marked this pull request as ready for review April 4, 2024 13:43
@jamesduncombe jamesduncombe added the fast deployment Includes a FAST deployment. label Apr 4, 2024
@jamesduncombe jamesduncombe merged commit f226c96 into main Apr 4, 2024
2 checks passed
@jamesduncombe jamesduncombe deleted the features/sc-9185-gasless-transactions-ops branch April 4, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fast deployment Includes a FAST deployment.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant